On Saturday 13 of October 2012 00:14:39 Sylwester Nawrocki wrote:
On 10/12/2012 11:54 PM, Tomasz Figa wrote:
quoted
quoted
quoted
+ if (of_get_property(dp_node, "interlaced", NULL))
+ dp_video_config->interlaced = 1;
of_property_read_bool() could also be used here.
Wouldn't it make the property mandatory?
No, it wouldn't. of_property_read_bool() uses of_find_property()
internally. It just returns true if property is found or false
otherwise.
Right, sorry. I thought that all of_property_read_* return error in case
of missing property.
Anyway, it appears of_get_property(..., NULL) pattern
is commonly used for boolean properties.
I guess all three of them should be fine in this case, but since there is
a dedicated function for bool, it might be the best solution here indeed.
Best regards,
Tomasz Figa