Re: [PATCH V5 1/2] video: exynos_dp: Add device tree support to DP driver

From
Sylwester Nawrocki <hidden>
Date
2012-10-12 22:14:39
Also in
linux-fbdev, linux-samsung-soc
Reply to
Tomasz Figa, 2012-10-12
On 10/12/2012 11:54 PM, Tomasz Figa wrote:
quoted
quoted
+	if (of_get_property(dp_node, "interlaced", NULL))
+		dp_video_config->interlaced = 1;
of_property_read_bool() could also be used here.
Wouldn't it make the property mandatory?
No, it wouldn't. of_property_read_bool() uses of_find_property() 
internally. It just returns true if property is found or false 
otherwise. Anyway, it appears of_get_property(..., NULL) pattern
is commonly used for boolean properties.
I would just use of_find_property here, instead of of_get_property.

Best regards,
Tomasz Figa
Thread (11 messages) 11 messages, 6 authors, last reply 2012-10-16
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help