Re: [PATCH 3/3] i2c: nomadik: Add Device Tree support to the Nomadik I2C driver
From: Linus Walleij <hidden>
Date: 2012-09-05 06:53:57
Also in:
linux-arm-kernel, linux-i2c, lkml
From: Linus Walleij <hidden>
Date: 2012-09-05 06:53:57
Also in:
linux-arm-kernel, linux-i2c, lkml
On Wed, Sep 5, 2012 at 8:41 AM, Lee Jones [off-list ref] wrote:
On Tue, Sep 04, 2012 at 07:27:10PM +0200, Linus Walleij wrote:quoted
On Tue, Sep 4, 2012 at 4:28 PM, Arnd Bergmann [off-list ref] wrote:quoted
In this particular case, we don't have a single board file providing a struct nmk_i2c_controller definition for platform data, so the best way to handle this IMHO is to remove the header file with the platform data definition, and just encode the defaults in the driver.Alessandro Rubini is actively working on bridging this (and other amba_device primecells) to PCI, that is the reason why it was recently converted to an amba_device. How is he then supposed to get the proper parameters into the driver? Note that the PCI ID is no help at all since the parameters depend on what is connected to the I2C bus, not on what it itself is connected to. Isn't platform data used in such cases?So why can't Alessandro continue to use Platform Data in the normal way?
He probably can, this is not an argument about that, what I am worried about is Arnd's suggestion to delete the platform data header if there are potential users of it. Yours, Linus Walleij