Thread (13 messages) 13 messages, 6 authors, 2012-09-05

Re: [PATCH 3/3] i2c: nomadik: Add Device Tree support to the Nomadik I2C driver

From: Rob Herring <hidden>
Date: 2012-09-03 15:09:42
Also in: linux-arm-kernel, linux-i2c, lkml

On 09/03/2012 09:35 AM, Linus Walleij wrote:
On Mon, Sep 3, 2012 at 4:33 PM, Stephen Warren [off-list ref] wrote:
quoted
On 09/03/2012 05:58 AM, Linus Walleij wrote:
quoted
On Mon, Sep 3, 2012 at 1:32 PM, Lee Jones [off-list ref] wrote:
quoted
No, this is wrong. Platform data should not override DT.

If DT is enabled and passed, it should have highest priority.
No, that's wrong. If platform data is specified, it overrides DT, so
that if the DT needs any fixup, it can be provided using platform data.
Thanks Stephen, now there are two of us saying this, Lee please
follow this design pattern.

(Unless Rob/Grant start shouting counter-orders...)
Ideally, you only use DT or platform_data and you override DT with a new
DTB. Hopefully we can ultimately remove platform_data or all but parts
that can't be described in DT (i.e. function callouts).

But if you are handling both, then I agree that platform_data should
override DT.

Rob
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help