Re: [PATCH v3 0/6] mmc: dw_mmc: add support for device tree based instantiation

On 07/20/2012 07:47 AM, Kukjin Kim wrote:

Thomas Abraham wrote:

quoted

On 19 July 2012 20:58, Jaehoon Chung [off-list ref] wrote:

quoted

Hi Thomas,

I think not good that added the samsung specific code into dw_mmc-

pltfm.c

quoted

How about separating to dw-mmc-exynos.c?

I am not sure of this. The only samsung specific code in
dw_mmc-pltfm.c file is the data for of_device_id instances. The clock
lookup added into this file in the 3rd patch does not cause any harm
on non-samsung SoC's which might not define those clocks (on clock
lookup failure, there are only warning printed, the driver's probe
does not fail.

I agree with Thomas' opinion, in addition, the dw_mmc-pltfm.c file can
support that, so adding dw-mmc-exynos.c is not needed now.

quoted

I would prefer not to add separate file for Exynos SoC's for now.
Splitting into different files will need to defined new callbacks
which I fell is not really required.

Then where is the callback function located?

Best Regards,
Jaehoon Chung

quoted

Yes.

Thanks.

Best regards,
Kgene.
--
Kukjin Kim [off-list ref], Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.

--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html