Re: [PATCH v2 06/10] ARM: tegra: pcie: Add MSI support
From: Stephen Warren <hidden>
Date: 2012-06-12 05:33:58
Also in:
linux-arm-kernel, linux-pci, linux-tegra
On 06/11/2012 11:07 PM, Thierry Reding wrote:
* Stephen Warren wrote:quoted
On 06/11/2012 09:05 AM, Thierry Reding wrote:quoted
This commit adds support for message signaled interrupts to the Tegra PCIe controller. Based on code by Krishna Kishore [off-list ref].
...
quoted
Why allocate pcie->msi separately; why not include the fields directly into struct tegra_pcie_info *pcie?
...
Second, and more importantly, this will keep the size of struct tegra_pcie_info smaller if PCI_MSI is not selected because there is just one unused pointer instead of five unused fields.
Well, you can always ifdef out the structure fields too, right?