Re: [PATCH] I2C: OMAP: fix build breakage when CONFIG_OF is not set

Hi Luca,

On 2/8/2012 12:25 PM, Luciano Coelho wrote:

On Wed, 2012-02-08 at 16:42 +0530, Shubhrajyoti Datta wrote:

quoted

On Wed, Feb 8, 2012 at 4:34 PM, Luciano Coelho[off-list ref]  wrote:

quoted

On Wed, 2012-02-08 at 12:59 +0200, Felipe Balbi wrote:

quoted

On Wed, Feb 08, 2012 at 12:56:52PM +0200, Luciano Coelho wrote:

quoted

Since commit 6145197be6cc0583fa1a2f4ec1079d366137061e, building

we generally like to see the commit subject here too. And adding the
abbreviated commit instead of the full sha1, wouldn't hurt either ;-)

Ok, different practices. :)

However  there was already a discurssion.
Anyways thanks for the patch.
http://permalink.gmane.org/gmane.linux.ports.arm.omap/69796

quoted

I'll send v2.

I think there was already a fix for this.

http://www.spinics.net/lists/linux-omap/msg63151.html

Anyways thanks for the patch.

Ah, okay.  Thanks for the info, I hadn't seen these.

Yeah, it looks like the OMAP fixes missed -rc2, but Tony sent the pull 
request [1].

Regards,
Benoit

[1] http://www.spinics.net/lists/linux-omap/msg63564.html