Thread (8 messages) flat view 8 messages, 4 authors, 2012-02-08

Re: [PATCH] I2C: OMAP: fix build breakage when CONFIG_OF is not set

From: Luciano Coelho <hidden>
Date: 2012-02-08 11:01:35
Also in: linux-i2c, linux-omap, lkml

On Wed, 2012-02-08 at 12:56 +0200, Luciano Coelho wrote: 
Since commit 6145197be6cc0583fa1a2f4ec1079d366137061e, building
i2c_omap.c breaks if CONFIG_OF is not set:

drivers/i2c/busses/i2c-omap.c: In function 'omap_i2c_probe':
drivers/i2c/busses/i2c-omap.c:1021: error: 'omap_i2c_of_match' undeclared (first use in this function)
drivers/i2c/busses/i2c-omap.c:1021: error: (Each undeclared identifier is reported only once
drivers/i2c/busses/i2c-omap.c:1021: error: for each function it appears in.)

This is because the definition of omap_i2c_of_match is #ifdef'd on
CONFIG_OF, but the usage of it is not.

Since the places where omap_ic2_of_match are prepared to get NULL
pointers if CONFIG_OF is not defined, we can simply define it to NULL.

Cc: Benoit Cousson <redacted>
Signed-off-by: Luciano Coelho <redacted>
---
Forgot to say that I think this should go into 3.3, since it's a build
break.

-- 
Cheers,
Luca.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help