Thread (58 messages) 58 messages, 15 authors, 2011-12-07

Re: [PATCH 1/2] of/irq: Get rid of NO_IRQ usage

From: Linus Torvalds <torvalds@linux-foundation.org>
Date: 2011-12-06 21:25:33
Also in: linux-ide, linux-next, lkml

On Tue, Dec 6, 2011 at 1:22 PM, Rob Herring [off-list ref] wrote:
This warning code is really ugly. Can we just drop it? In my searching
of in kernel dts files, there's only 1 instance I have found (Versatile
AB watchdog) that would hit this.
I do agree. Especially since we never got any input on whether it works or not.
If not, you don't need to handle irq_create_of_mapping return as that is
already always 0 for no irq or error.
Yeah, I'd like to just remove NO_IRQ from the OF paths. Afaik, it
hasn't worked as NO_IRQ before anyway, so even if the rest of the
drivers end up continuing using NO_IRQ, the OF-enabled ones on ARM
should just stop. There can't be many of those yet.

                          Linus
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help