Re: [PATCH v2 3/5] regulator: helper routine to extract regulator_init_data

On Mon, Oct 24, 2011 at 02:23:50PM +0530, Rajendra Nayak wrote:

On Monday 24 October 2011 01:47 PM, Grant Likely wrote:

quoted

On Mon, Oct 24, 2011 at 11:32:19AM +0530, Rajendra Nayak wrote:

quoted

On Friday 21 October 2011 05:28 PM, Shawn Guo wrote:

quoted

On Fri, Oct 21, 2011 at 02:11:55PM +0530, Rajendra Nayak wrote:
[...]

quoted

quoted

+       /* find device_node and attach it */
+       rdev->dev.of_node = of_find_node_by_name(NULL, regulator_desc->name);

Shawn/Mark,

How about the driver passing the of_node to be associated with the
regulator, as part of regulator_desc, to the regulator core,
instead of this complete DT search and the restriction of having
to match DT node names with names in regulator_desc.

If you agree that we should try to get DT core from creating
'struct dev' for each regulator, the of_node is not being attached
to any 'struct dev' in regulator driver either, so there is no
difference between finding the of_node in regulator driver and in
regulator core.

-- 
Regards,
Shawn