Thread (48 messages) 48 messages, 10 authors, 2011-06-24

Re: [PATCH 1/3] serial/imx: add device tree support

From: Grant Likely <hidden>
Date: 2011-06-24 04:05:23
Also in: linux-arm-kernel, lkml, netdev

On Thu, Jun 23, 2011 at 9:49 PM, Shawn Guo [off-list ref] wrote:
On Thu, Jun 23, 2011 at 05:11:54PM -0600, Grant Likely wrote:
quoted
quoted
+               int devid = get_alias_name_id(pp->name, devname);
+
+               /* We do not want to proceed this sentinel one */
+               if (!strcmp(pp->name, "name") && !strcmp(pp->value, "aliases"))
+                       break;
Skipping the 'name' property is good, but I don't think you need to
check the value.  You should also skip the "phandle" property.
Ok. I have not seen "phandle" property in aliases node though.  Can
you give me an example, so that I can make one up for testing?
It's a standard property that shows up automatically if any node
happens to have a phandle reference to another node.  The name will be
either "phandle" or "linux,phandle".  Search for "linux,phandle" in
drivers/of/fdt.c to see how that property is processed.

g.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help