Re: [PATCH V2 2/3] arm/dt: add very basic dts file for babbage board
From: Shawn Guo <hidden>
Date: 2011-03-08 03:11:55
On Tue, Mar 08, 2011 at 10:20:33AM +0800, Jason Hui wrote:
Hi, Shawn, On Mon, Mar 7, 2011 at 10:51 PM, Shawn Guo [off-list ref] wrote:quoted
Aha, Jason. Grant and I put many comments on v1 of this patch, but it seems that v2 is identical to v1, except adding Rob Herring sign-off.Please compare with v1 and say it once again, It should include the
Oops! Sorry, I messed up with my local branches last night, probably because it was late :)
grant and your comments except the mxctty1 due to I think that it's not one issue, So, I did not take your comments.
I still think it's an issue that the dt kernel needs a different console cmdline from the non-dt one.
But I observed that some comments as Grant suggest to use decimal not hex value for #address-cells and #size-cells, not applied to this file globally, I will fix it in the V3 patch if need.quoted
On Mon, Mar 07, 2011 at 09:05:59PM +0800, Jason Liu wrote:quoted
Signed-off-by: Jason Liu <redacted> Singed-off-by: Rob Herring [off-list ref] --- arch/arm/boot/dts/babbage.dts | 110 +++++++++++++++++++++++++++++++++++++++++ 1 files changed, 110 insertions(+), 0 deletions(-)
-- Regards, Shawn