Thread (50 messages) 50 messages, 5 authors, 2011-02-22

Re: [sodaville] [PATCH OF 13/14] rtc/cmos: add OF bindings

From: Grant Likely <hidden>
Date: 2011-02-17 16:46:54
Also in: lkml

On Thu, Feb 17, 2011 at 6:26 AM, Sebastian Andrzej Siewior
[off-list ref] wrote:
* Grant Likely | 2011-02-16 15:11:08 [-0700]:
quoted
quoted
diff --git a/Documentation/powerpc/dts-bindings/rtc-cmos.txt b/Documentation/powerpc/dts-bindings/rtc-cmos.txt
new file mode 100644
index 0000000..7382989
--- /dev/null
+++ b/Documentation/powerpc/dts-bindings/rtc-cmos.txt
Move to Documentation/devicetree/bindings/rtc/
moved.
quoted
quoted
diff --git a/drivers/rtc/rtc-cmos.c b/drivers/rtc/rtc-cmos.c
index c7ff8df..2709e00 100644
--- a/drivers/rtc/rtc-cmos.c
+++ b/drivers/rtc/rtc-cmos.c
@@ -1162,6 +1205,9 @@ static struct platform_driver cmos_platform_driver = {
 #ifdef CONFIG_PM
             .pm             = &cmos_pm_ops,
 #endif
+#if defined(CONFIG_OF)
+            .of_match_table = of_cmos_match,
+#endif
The #if defined(CONFIG_OF) is no longer necessary around
.of_match_table, particularly if you have a #else above that #defines
of_cmos_match to NULL.
Kinda does not work. I get here:
|drivers/rtc/rtc-cmos.c:1209:3: error: unknown field â  of_match_tableâ   specified in initializer

I rebased on top of -rc5. Is this something new you describing?
Base your patch on top of my devicetree/next branch.  That's the
branch that tglx will be applying them on top of them to get your
changes to generic pci dt support code.

g.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help