Re: [PATCH TIP 03/14] x86/dtb: Add a device tree for CE4100

On Thu, Jan 27, 2011 at 02:41:47PM +0530, Sebastian Andrzej Siewior wrote:

* David Gibson | 2011-01-27 15:00:27 [+1000]:

quoted

quoted

+					>;
+
+				i2c-controller@15a00,0,0 {

Uh.. that unit address does not look right.  The encoding of PCI
3-cell addresses into a unit address string is not simply comma
separated cells.  I forget the details, so you'll need to check the OF
PCI binding.

Grant wrote [0]:
|You'll also note that I added ',0,0' to the end of the address.
|That's because the node address reflects the parent bus address format
|which uses 3 cells in this case.

It is quite possible I was mistaken on this point.  The PCI binding is
not my area of strength.

g.