Re: [PATCH v2] spi: New driver for Altera SPI

On Sun, Jan 16, 2011 at 11:22 PM, Thomas Chou [off-list ref] wrote:

On 01/17/2011 01:59 PM, Stephen Rothwell wrote:

quoted

quoted

+/*
+ * struct altera_spi_platform_data - platform data of the Altera SPI
+ * @interrupt: use intrrupt driven data transfer.
+ */
+struct altera_spi_platform_data {
+       int interrupt;
+};

Is there some reason that this struct definition cannot just be placed
in spi_altera.c and so save a whole extra file (and its inclusion)?

Hi Stephen,

It is needed for board configuration file to attach this platform data,
which is used to choose between interrupt driven data transfer or polling
method. The data transfer rate is usually faster for polling, as interrupt
overhead is higher.

In this case, that decision could simply be made based on whether or
not the device has an irq resource.  No irq == polled mode.

g.