Re: [PATCH v2] spi: New driver for Altera SPI
From: Stephen Rothwell <hidden>
Date: 2011-01-17 06:00:15
Also in:
linux-spi, lkml
Hi Thomas, On Mon, 17 Jan 2011 13:46:40 +0800 Thomas Chou [off-list ref] wrote:
This patch adds a new SPI driver to support the Altera SOPC Builder SPI component. It uses the bitbanging library.
Just a general query.
quoted hunk ↗ jump to hunk
diff --git a/include/linux/spi/spi_altera.h b/include/linux/spi/spi_altera.h new file mode 100644 index 0000000..b3d7f69 --- /dev/null +++ b/include/linux/spi/spi_altera.h@@ -0,0 +1,12 @@ +#ifndef _LINUX_SPI_SPI_ALTERA_H +#define _LINUX_SPI_SPI_ALTERA_H + +/* + * struct altera_spi_platform_data - platform data of the Altera SPI + * @interrupt: use intrrupt driven data transfer. + */ +struct altera_spi_platform_data { + int interrupt; +};
Is there some reason that this struct definition cannot just be placed in spi_altera.c and so save a whole extra file (and its inclusion)? -- Cheers, Stephen Rothwell sfr-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org http://www.canb.auug.org.au/~sfr/