Thread (75 messages) 75 messages, 7 authors, 2021-07-24

Re: [PATCH 06/11] nvme: Implement In-Band authentication

From: Stephan Müller <hidden>
Date: 2021-07-18 12:48:08
Also in: linux-nvme

Am Sonntag, 18. Juli 2021, 14:43:43 CEST schrieb Hannes Reinecke:

Hi Hannes,
quoted
quoted
+	size += 2 * chap->hash_len;
+	if (ctrl->opts->dhchap_auth) {
+		get_random_bytes(chap->c2, chap->hash_len);
Why are you using CRYPTO_RNG_DEFAULT when you are using get_random_bytes
here?
Errm ... do I?
Seems that my crypto ignorance is showing here; 'get_random_bytes()' is
the usual function we're using for drivers; if there is another way for
crypto please enlighten me.
Apologies, I was looking at CONFIG_RNG where you set CRYPTO_RNG_DEFAULT. 
Please ignore my comment here.

Ciao
Stephan

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help