On Sat, Jul 17, 2021 at 04:00:20PM +0200, Hannes Reinecke wrote:

On 7/17/21 8:16 AM, Sagi Grimberg wrote:

quoted

quoted

Add RFC4648-compliant base64 encoding and decoding routines.

Looks good to me (although didn't look in the logic itself).
Can you maybe mention where was this taken from?

Umm ... yeah, I guess I can; I _think_ I've copied it from base64 routines
in fs/crypto/fname.c, but I'll check.

Note that it wasn't simply a copy, as you changed the variant of base64 that is
implemented.  So please make sure that you are very clear about which variant of
base64 it is, and update all the comments accordingly.

- Eric