Re: [PATCH] hwrng: ba431 - Add dependency on HAS_IOMEM

On Tue, Jun 30, 2020 at 02:20:37PM +1000, Herbert Xu wrote:

On Mon, Jun 29, 2020 at 08:46:38PM +0800, kernel test robot wrote:

quoted

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head:   c28e58ee9dadc99f79cf16ca805221feddd432ad
commit: 0289e9be5dc26d84dda6fc5492f08ca1ff599744 [1846/4145] hwrng: ba431 - add support for BA431 hwrng
config: s390-zfcpdump_defconfig (attached as .config)
compiler: s390-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        git checkout 0289e9be5dc26d84dda6fc5492f08ca1ff599744
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=s390 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <redacted>

All errors (new ones prefixed by >>):

   s390-linux-ld: drivers/char/hw_random/ba431-rng.o: in function `ba431_trng_probe':

quoted

quoted

ba431-rng.c:(.text+0xd4): undefined reference to `devm_ioremap_resource'

This patch should fix the problem:

---8<---
The ba431 driver depends on HAS_IOMEM and this was missing from
the Kconfig file.

Indeed, it was missing. Sorry for that and thanks for the fix!