Thread (2 messages) flat view 2 messages, 2 authors, 2020-06-30
STALE2277d

[PATCH] hwrng: ba431 - Add dependency on HAS_IOMEM

From: Herbert Xu <herbert@gondor.apana.org.au>
Date: 2020-06-30 04:20:50
Also in: oe-kbuild-all
Subsystem: hardware random number generator core, the rest · Maintainers: Olivia Mackall, Herbert Xu, Linus Torvalds

On Mon, Jun 29, 2020 at 08:46:38PM +0800, kernel test robot wrote:
tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head:   c28e58ee9dadc99f79cf16ca805221feddd432ad
commit: 0289e9be5dc26d84dda6fc5492f08ca1ff599744 [1846/4145] hwrng: ba431 - add support for BA431 hwrng
config: s390-zfcpdump_defconfig (attached as .config)
compiler: s390-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        git checkout 0289e9be5dc26d84dda6fc5492f08ca1ff599744
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=s390 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <redacted>

All errors (new ones prefixed by >>):

   s390-linux-ld: drivers/char/hw_random/ba431-rng.o: in function `ba431_trng_probe':
quoted
quoted
ba431-rng.c:(.text+0xd4): undefined reference to `devm_ioremap_resource'
This patch should fix the problem:

---8<---
The ba431 driver depends on HAS_IOMEM and this was missing from
the Kconfig file.

Reported-by: kernel test robot <redacted>
Fixes: 0289e9be5dc2 ("hwrng: ba431 - add support for BA431 hwrng")
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
diff --git a/drivers/char/hw_random/Kconfig b/drivers/char/hw_random/Kconfig
index 7b876dfdbaaf..edbaf6154764 100644
--- a/drivers/char/hw_random/Kconfig
+++ b/drivers/char/hw_random/Kconfig
@@ -76,6 +76,7 @@ config HW_RANDOM_ATMEL
 
 config HW_RANDOM_BA431
 	tristate "Silex Insight BA431 Random Number Generator support"
+	depends on HAS_IOMEM
 	default HW_RANDOM
 	help
 	  This driver provides kernel-side support for the Random Number
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help