Re: [PATCH v6 08/14] crypto: caam - make CAAM_PTR_SZ dynamic

On Tue, Jul 23, 2019 at 2:57 AM Horia Geanta [off-list ref] wrote:

On 7/17/2019 6:25 PM, Andrey Smirnov wrote:

quoted

In order to be able to configure CAAM pointer size at run-time, which
needed to support i.MX8MQ, which is 64-bit SoC with 32-bit pointer
size, convert CAAM_PTR_SZ to refer to a global variable of the same
name ("caam_ptr_sz") and adjust the rest of the code accordingly. No
functional change intended.

I am seeing compilation errors like:

In file included from drivers/crypto/caam/ctrl.c:25:0:
drivers/crypto/caam/qi.h:87:6: error: variably modified 'sh_desc' at file scope
  u32 sh_desc[MAX_SDLEN];
      ^

Adding comments for this commit, since it looks like the fixes
should be included here (related to DESC_JOB_IO_LEN vs. DESC_JOB_IO_LEN_MAX).

Please make sure caam/qi and and caam/qi2 drivers are at least compile-tested.

By caam/qi I am referring to:
CONFIG_CRYPTO_DEV_FSL_CAAM_CRYPTO_API_QI=y/m

and caam/qi2:
CONFIG_CRYPTO_DEV_FSL_DPAA2_CAAM=y/m

Sorry about that, should be fixed in v7.

Thanks,
Andrey Smirnov