Re: [PATCH net-next v3 02/17] zinc: introduce minimal cryptography library

On Sep 17, 2018, at 8:28 AM, Jason A. Donenfeld [off-list ref] wrote:

On Mon, Sep 17, 2018 at 4:52 PM Andy Lutomirski [off-list ref] wrote:

quoted

quoted

* (Nit) The GCC command line -include'd .h files contain variable and
function definitions so they are actually .c files.

Hmm. I would suggest just getting rid of the -include magic entirely.  The resulting ifdef will be more comprehensible.

I really don't think so, actually. The way the -include stuff works
now is that the glue code is inlined in the same place that the
assembly object file is added to the build object list, so it gels
together cleanly, as the thing is defined and set in one single place.
I could go back to the ifdefs - and even make them as clean as
possible - but I think that puts more things in more places and is
therefore more confusing. The -include system now works extremely
well.

Is it really better than:

#ifdef CONFIG_X86_64
#include "whatever"
#endif

It seems a more obfuscated than needed to put the equivalent of that
into the Makefile, and I don't think people really like searching
through the Makefile to figure out why the code does what it does.