Re: [PATCH net-next v3 02/17] zinc: introduce minimal cryptography library

On Sep 12, 2018, at 11:39 PM, Milan Broz [off-list ref] wrote:

quoted

On 13/09/18 01:45, Andy Lutomirski wrote:
On Wed, Sep 12, 2018 at 3:56 PM, Ard Biesheuvel

... 

quoted

b) Crypto that is used dynamically.  This includes dm-crypt
(aes-xts-plain64, aes-cbc-essiv, etc), all the ALG_IF interfaces, a
lot of IPSEC stuff, possibly KCM, and probably many more.  These will
get comparatively little benefit from being converted to a zinc-like
interface.  For some of these cases, it wouldn't make any sense at all
to convert them.  Certainly the ones that do async hardware crypto
using DMA engines will never look at all like zinc, even under the
hood.

Please note, that dm-crypt now uses not only block ciphers and modes,
but also authenticated encryption and hashes (for ESSIV and HMAC
in authenticated composed modes) and RNG (for random IV).
We use crypto API, including async variants (I hope correctly :)

Right. And all this is why I don’t think dm-crypt should use zinc, at least not any time soon.