Re: [PATCH v4 11/14] treewide: Prepare to remove VLA usage for AHASH_REQUEST_ON_STACK

On 19 July 2018 at 12:13, Ard Biesheuvel [off-list ref] wrote:

quoted

On 19 Jul 2018, at 12:09, Kees Cook [off-list ref] wrote:

On Wed, Jul 18, 2018 at 7:55 PM, Ard Biesheuvel
[off-list ref] wrote:

quoted

I have only build tested it, so if you make sure that it does not break anything, please go ahead.

I can give it a spin; what's the best way? Is CONFIG_CRYPTO_MANAGER=y
sufficient?

You should be able to test ccm(aes) with tcrypt, yes

Apologies, I should have been more clear here. I was replying on my
phone while attending a meeting.

The builtin test will only kick in for chaining mode templates if they
are instantiated by something that invokes the algorithm, such as
loading tcrypt.ko with mode=37 (assuming that ccm(aes) has to be
instantiated from crypto/ccm.c and some AES cipher rather than being
provided directly by, e.g., arm64's AES-CCM driver)

I just did the tcrypt myself, and the patch appears to be fine. Let me
know if you want me to spin the patch.