Re: [PATCH v4 11/14] treewide: Prepare to remove VLA usage for AHASH_REQUEST_ON_STACK
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: 2018-07-13 05:21:08
Also in:
dm-devel, lkml
On Thu, Jul 12, 2018 at 10:17:29PM -0700, Kees Cook wrote:
Then why does the instrumented tcrypt output show the huge size? Is tcrypt doing something incorrectly?
tcrypt doesn't even use AHASH_REQUEST_ON_STACK so I don't understand your point.
What is the correct value to use for AHASH_REQUEST_ON_STACK?
As I said to arrive at a fixed value you should examine all sync ahash algorithms (e.g., all shash ones plus ahash ones marked as sync if there are any). Cheers, -- Email: Herbert Xu [off-list ref] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt