----- Original Message -----

From: "Herbert Xu" <herbert@gondor.apana.org.au>
Sent: Monday, August 3, 2015 6:31:20 PM

On Mon, Aug 03, 2015 at 11:14:37AM -0500, Aaron Sierra wrote:

quoted

Compiling the talitos driver with my GCC 4.3.1 e500v2 cross-compiler
resulted in a failed build due to the anonymous union/structures
introduced in this commit:

  crypto: talitos - enhanced talitos_desc struct for SEC1

The build error was:

  drivers/crypto/talitos.h:56: error: unknown field 'len' specified in
  initializer
  drivers/crypto/talitos.h:56: warning: missing braces around initializer
  drivers/crypto/talitos.h:56: warning: (near initialization for
  'zero_entry.<anonymous>')
  drivers/crypto/talitos.h:57: error: unknown field 'j_extent' specified in
  initializer
  drivers/crypto/talitos.h:58: error: unknown field 'eptr' specified in
  initializer
  drivers/crypto/talitos.h:58: warning: excess elements in struct
  initializer
  drivers/crypto/talitos.h:58: warning: (near initialization for
  'zero_entry')
  make[2]: *** [drivers/crypto/talitos.o] Error 1
  make[1]: *** [drivers/crypto] Error 2
  make: *** [drivers] Error 2

This patch eliminates the errors by moving the static constant
zero_entry to the talitos_private structure. As a member of that
structure, zero_entry gets initialized for free (and compatibly) by
the kzalloc() during device probe.

Why? A static variable is always zeroed.  Please just get rid
of the initialisation and it will work.

Thanks for elaborating. I'll make the change.

-Aaron