Thread (20 messages) 20 messages, 4 authors, 2015-08-24

Re: [PATCH 1/2] crypto: KEYS: convert public key to the akcipher API

From: Tadeusz Struk <hidden>
Date: 2015-08-24 17:46:25
Also in: lkml

Hi Stephan,

On 08/15/2015 11:08 AM, Stephan Mueller wrote:
Am Mittwoch, 12. August 2015, 20:54:39 schrieb Tadeusz Struk:

Hi Tadeusz,
quoted
@@ -41,7 +41,7 @@ struct pkcs7_parse_context {
static void pkcs7_free_signed_info(struct pkcs7_signed_info *sinfo)
{
	if (sinfo) {
-		mpi_free(sinfo->sig.mpi[0]);
+		kfree(sinfo->sig.s);
kzfree?
quoted
		kfree(sinfo->sig.digest);
kzfree?
quoted
		kfree(sinfo->signing_cert_id);
		kfree(sinfo);
kzfree (due to ->msdigest)?
Sorry for late response. I was on vacation.
All these above are module signatures, which are not sensitive,
so no need to zero the buffers on free.
The only thing that is sensitive is the private key,
which is only used for signing modules on make modules_install
and never included in the kernel.
Thanks,
T
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help