Thread (20 messages) 20 messages, 4 authors, 2015-08-24

Re: [PATCH 2/2] crypto: qat - Don't move data inside output buffer

From: Herbert Xu <herbert@gondor.apana.org.au>
Date: 2015-08-17 08:49:19
Also in: lkml

On Fri, Aug 14, 2015 at 07:21:29AM -0700, Tadeusz Struk wrote:
Yes, that was wrong, sorry. The reason I wanted to change it is that
the SW implementation can return a number with leading zeros.
This is because mpi_read_buffer() returns the whole thing.
I think mpi_read_buffer is broken.  It should return exactly the
same thing as mpi_get_buffer, except that it should do so in the
buffer provided instead of allocating a new one.

So it most certainly should remove all leading zero bytes.

Cheers,
-- 
Email: Herbert Xu [off-list ref]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help