Thread (16 messages) 16 messages, 3 authors, 2015-05-22

Re: random: Wake up all getrandom(2) callers when pool is ready

From: Theodore Ts'o <tytso@mit.edu>
Date: 2015-05-21 19:17:47
Also in: lkml

On Thu, May 21, 2015 at 04:19:54PM +0800, Herbert Xu wrote:
On Thu, May 21, 2015 at 09:55:17AM +0200, Stephan Mueller wrote:
quoted
So, I will create a 2nd wait queue in random.c for uninterruptible waits, 
change the get_blocking_random_bytes back to void and use wait_event to wait 
for the initialization.
Hold your horses.  You don't need a second queue, you just need to
change wake_up_interruptible to wake_up.

Hmm, in fact shouldn't this be wake_up_all? Otherwise what are the
other getrandom(2) callers going to do? Ted?
Yes, this should definitely be wake_up_all()

							- Ted
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help