Re: [PATCH v9 3/5] crypto: drbg - add async seeding operation
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: 2015-05-21 06:56:56
Also in:
lkml
On Thu, May 21, 2015 at 08:53:13AM +0200, Stephan Mueller wrote:
Thank you for pointing that out - I have seen that too. But the crux is that when using wait_event, the cancel function to serialize the destruction code path will *not* return at all, even when the async callback function completed successfully. Hence the choice for wait_event_interruptible
Why is that? It should return when the pool is initialised and your work completes. If it does not then that means either the pool isn't initialising or somehow your code is racy and getting stuck. If it's racy then wait_event_interruptible is just hiding the real problem. Cheers, -- Email: Herbert Xu [off-list ref] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt