Re: [PATCH 3/6 v2] crypto:s5p-sss: Add support for SSS module on Exynos
From: Sachin Kamat <hidden>
Date: 2014-01-09 09:33:01
Also in:
linux-samsung-soc, lkml
Hi Naveen, On 9 January 2014 10:29, Naveen Krishna Chatradhi [off-list ref] wrote:
quoted hunk ↗ jump to hunk
This patch adds new compatible and varient to support the SSS module on Exynos4 (Exynos4210), Exynos5 (Exynos5420 and Exynos5250) for which 1. AES register are at an offset of 0x200 and 2. hash interrupt is not available Signed-off-by: Naveen Krishna Ch <redacted> CC: Herbert Xu <herbert@gondor.apana.org.au> CC: David S. Miller <davem@davemloft.net> CC: Vladimir Zapolskiy <redacted> TO: <redacted> CC: <redacted> --- Changes since v1: 1. Used varient struct 2. Added description in Documentation .../devicetree/bindings/crypto/samsung-sss.txt | 20 +++++++++ drivers/crypto/s5p-sss.c | 43 ++++++++++++++------ 2 files changed, 51 insertions(+), 12 deletions(-)diff --git a/Documentation/devicetree/bindings/crypto/samsung-sss.txt b/Documentation/devicetree/bindings/crypto/samsung-sss.txt index 0e45b0d..4531da2 100644 --- a/Documentation/devicetree/bindings/crypto/samsung-sss.txt +++ b/Documentation/devicetree/bindings/crypto/samsung-sss.txt@@ -8,13 +8,33 @@ The SSS module in S5PV210 SoC supports the following: -- SHA-1/SHA-256/MD5/HMAC (SHA-1/SHA-256/MD5)/PRNG -- PRNG: Pseudo Random Number Generator +The SSS module in Exynos4 (Exynos4210) and +Exynos5 (Exynos5420 and Exynos5250) SoCs +supports the following also: +-- ARCFOUR (ARC4) +-- True Random Number Generator (TRNG) +-- Secure Key Manager + Required properties: - compatible : Should contain entries for this and backward compatible SSS versions: - "samsung,s5p-secss" for S5PV210 SoC. + - "samsung,exynos-secss" for Exynos4210, Exynos5250 and Exynos5420 SoCs.
Shouldn't the compatible string be more specific with the name of the first SoC that had this IP? -- With warm regards, Sachin