Re: [PATCH 5/5] ARM: exynos5420: add dt node for sss module
From: Tomasz Figa <hidden>
Date: 2014-01-08 00:32:57
Also in:
linux-samsung-soc, lkml
On Tuesday 07 of January 2014 17:21:49 Naveen Krishna Ch wrote:
From: Naveen Krishna Chatradhi <redacted> this patch adds the device tree nodes for SSS module found on Exynos5420
nit: Sentences in English start with a capital letter. Also this patch adds one node, not few of them as the description suggests. Also patch subject should start with ARM: dts: prefix.
quoted hunk ↗ jump to hunk
Signed-off-by: Naveen Krishna Chatradhi <redacted> TO: <redacted> CC: Kukjin Kim <redacted> CC: <redacted> --- arch/arm/boot/dts/exynos5420.dtsi | 10 ++++++++++ 1 file changed, 10 insertions(+)diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi index 11dd202..97045f9 100644 --- a/arch/arm/boot/dts/exynos5420.dtsi +++ b/arch/arm/boot/dts/exynos5420.dtsi@@ -652,4 +652,14 @@ clocks = <&clock 319>, <&clock 318>; clock-names = "tmu_apbif", "tmu_triminfo_apbif"; }; + + sss: sss {
Node name should be sss@10830000 as per ePAPR node naming recommendation. Best regards, Tomasz