Hi Dov,


On 8/31/21 6:37 AM, Dov Murik wrote:

quoted

+
+	if (!platform_device_register(&guest_req_device))
+		dev_info(&guest_req_device.dev, "secret phys 0x%llx\n", snp_secrets_phys);

Should you return the error code from platform_device_register() in case
it fails (returns something other than zero)?

Yes, I will fix it in next rev. Will return a non-zero on failure to 
register the device.

thanks