Hi,

On 10/15/21 8:58 PM, Mark Brown wrote:

On Fri, Oct 15, 2021 at 08:50:13PM +0200, Hans de Goede wrote:

quoted

Are you happy with the platform_data for this driver as defined in
patch 4/12 ? :

Some of the other review comments lead me to believe that you'd be
sending out a new version at some point?

That is correct.

quoted

https://lore.kernel.org/platform-driver-x86/20211008162121.6628-1-hdegoede@redhat.com/T/#m745cc1191f531a57ae7998f5c8817ba9a46f0fed (local)

I am very confused about why it's in the driver without a DMI quirk
and/or clear comments about why and saying that this is a terrible
example to copy.

The DMI quirks live in the ACPI glue code under drivers/platform/x86,
that code instantiates the MFD cell and sets the platform-data
as part of the cell.

I'd also expect to get compile test coverage for the driver.

Ack, Stephen made the same remark for the clk driver. I'll fix
this for the next version.

Regards,

Hans