Hi,

On 10/15/21 6:46 PM, Mark Brown wrote:

On Mon, Oct 11, 2021 at 01:43:40PM +0200, Hans de Goede wrote:

quoted

To make this work when everything is build as a module patch 12/12
adds the following to the PMIC-MFD-driver:

quoted

MODULE_SOFTDEP("pre: clk-tps68470 tps68470-regulator");

quoted

This will make modprobe load the clk and regulator drivers
before it loads the main/MFD tps68470 driver.

I feel nervous about this being reliable with all userspaces - IIRC
there was an alternative implementation of the modules stuff in
userspace and someone could always be doing insmod.  OTOH without better
in kernel dependency management and/or more standards based firmware
interfaces I guess we're stuck with this.

Right, this is all less then ideak, but I believe that this is the
best we can do for now.

Are you happy with the platform_data for this driver as defined in
patch 4/12 ? :

https://lore.kernel.org/platform-driver-x86/20211008162121.6628-1-hdegoede@redhat.com/T/#m745cc1191f531a57ae7998f5c8817ba9a46f0fed (local)

And are you ok with me doing an immutable-branch based on
5.15-rc1 with just the patch adding the platform_data
in there ?  The platform_data is used/shared by most patches
in this series. So the idea is to have an immutable branch
which can be shared/merged by all subsystems which have
patches in this patch series.

Regards,

Hans