Thread (20 messages) 20 messages, 3 authors, 2021-02-06

Re: [PATCH v3] cifs: report error instead of invalid when revalidating a dentry fails

From: Shyam Prasad N <hidden>
Date: 2021-02-05 22:47:00
Also in: linux-fsdevel

Hi Aurélien,

xfstest 070 was failing today with this patch.
It looks like we need to handle ESTALE here, in addition to ENOENT.
ESTALE happens when the file type or inode number has changed on the
server, which indicates that it's a new entry.

Regards,
Shyam

On Tue, Feb 2, 2021 at 10:34 AM Aurélien Aptel [off-list ref] wrote:
Shyam Prasad N [off-list ref] writes:
quoted
This looks good to me.
Let me know if you get a chance to test it out. If not, I'll test it
on my setup tomorrow.
I've done some tests: the reproducer cannot trigger the bug, accessing a
deleted file invalidates, accessing an existing file revalidates. It looks
ok.

Cheers,
--
Aurélien Aptel / SUSE Labs Samba Team
GPG: 1839 CB5F 9F5B FB9B AA97  8C99 03C8 A49B 521B D5D3
SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg, DE
GF: Felix Imendörffer, Mary Higgins, Sri Rasiah HRB 247165 (AG München)

-- 
Regards,
Shyam
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help