Re: [PATCH v1] cifs: make nested cifs mount point dentries always valid to deal with signaled 'df'
From: Aurélien Aptel <hidden>
Date: 2021-02-01 10:33:20
Also in:
linux-fsdevel
From: Aurélien Aptel <hidden>
Date: 2021-02-01 10:33:20
Also in:
linux-fsdevel
Shyam Prasad N [off-list ref] writes:
Going by the documentation of d_revalidate:quoted
This function should return a positive value if the dentry is still valid, and zero or a negative error code if it isn't.In case of error, can we try returning the rc itself (rather than 0), and see if VFS avoids a dentry put? Because theoretically, the call execution has failed, and the dentry is not found to be invalid.
AFAIK mount points are pinned, you cannot rm or mv them so it seems we could make them always valid. I don't know if there are deeper and more subtle implications. The recent signal fixes are not fixing this issue. Cheers, -- Aurélien Aptel / SUSE Labs Samba Team GPG: 1839 CB5F 9F5B FB9B AA97 8C99 03C8 A49B 521B D5D3 SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg, DE GF: Felix Imendörffer, Mary Higgins, Sri Rasiah HRB 247165 (AG München)