On Fri. 19 mars 2021 at 18:56, Marc Kleine-Budde [off-list ref] wrote:

On 19.03.2021 18:47:06, Vincent MAILHOL wrote:

quoted

On Fri. 19 Mar 2021 at 17:39, Marc Kleine-Budde [off-list ref] wrote:

quoted

On 09.03.2021 16:28:37, Marc Kleine-Budde wrote:

quoted

On 09.03.2021 09:21:27, Stephane Grosjean wrote:

quoted

Since the peak_usb driver also supports the CAN-USB interfaces
"PCAN-USB X6" and "PCAN-Chip USB" from PEAK-System GmbH, this patch adds
their names to the list of explicitly supported devices.

Signed-off-by: Stephane Grosjean <redacted>
---
 drivers/net/can/usb/peak_usb/pcan_usb_fd.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/net/can/usb/peak_usb/pcan_usb_fd.c b/drivers/net/can/usb/peak_usb/pcan_usb_fd.c
index 6183a42f6491..8e6250c4c417 100644
--- a/drivers/net/can/usb/peak_usb/pcan_usb_fd.c
+++ b/drivers/net/can/usb/peak_usb/pcan_usb_fd.c

@@ -19,6 +19,8 @@

 MODULE_SUPPORTED_DEVICE("PEAK-System PCAN-USB FD adapter");
 MODULE_SUPPORTED_DEVICE("PEAK-System PCAN-USB Pro FD adapter");
+MODULE_SUPPORTED_DEVICE("PEAK-System PCAN-USB X6 adapter");
+MODULE_SUPPORTED_DEVICE("PEAK-System PCAN-Chip USB");

I've exchanged these, to correspond the order of the device ids.

Funny side note:
MODULE_SUPPORTED_DEVICE was a noop define. All uses have been globally
removed from Linus' tree after this patch hit linux-net/master, but
before it landed in Linus' tree.

Silly question but does it mean that we should not use
MODULE_SUPPORTED_DEVICE in newly submitted patches?

ACK - It's been removed from Linus' tree, see:

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=6417f03132a6952cd17ddd8eaddbac92b61b17e0

quoted

After seeing Stéphane's patch, I added it to my driver. Even if it is
a noop define, it adds meta information in the source code so I was
inclined to keep it.

As the noop define has been removed, the driver will no longer compile.

Got it, thanks for the link to the commit!


Yours sincerely,
Vincent