Re: [PATCH 1/3] can/peak_usb: add support of ethtool set_phys_id()
From: Marc Kleine-Budde <mkl@pengutronix.de>
Date: 2021-03-19 08:36:23
On 09.03.2021 13:15:27, Marc Kleine-Budde wrote:
quoted
diff --git a/drivers/net/can/usb/peak_usb/pcan_usb_pro.h b/drivers/net/can/usb/peak_usb/pcan_usb_pro.h index 6bb12357d078..421104ee29f4 100644 --- a/drivers/net/can/usb/peak_usb/pcan_usb_pro.h +++ b/drivers/net/can/usb/peak_usb/pcan_usb_pro.h@@ -115,6 +115,12 @@ struct __packed pcan_usb_pro_devid { __le32 serial_num; }; +#define FW_USBPRO_LED_DEVICE 0x00 +#define FW_USBPRO_LED_BLINK_FAST 0x01 +#define FW_USBPRO_LED_BLINK_SLOW 0x02 +#define FW_USBPRO_LED_ON 0x03 +#define FW_USBPRO_LED_OFF 0x04What about replacing the FW_ with PCAN_, so that we're using the same prefix within the driver? I can do this while applying.
I've replaced the FW_ with PCAN_ while applying the patch. Marc -- Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung West/Dortmund | Phone: +49-231-2826-924 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
Attachments
- signature.asc [application/pgp-signature] 488 bytes