Re: [PATCH] Add PEAK System USB adapters core driver
From: Oliver Hartkopp <socketcan@hartkopp.net>
Date: 2012-01-10 15:23:01
On 10.01.2012 11:17, Wolfgang Grandegger wrote:
quoted
drivers/net/can/usb/Kconfig | 1 + drivers/net/can/usb/Makefile | 1 + drivers/net/can/usb/peak_usb/Kconfig | 19 + drivers/net/can/usb/peak_usb/Makefile | 10 + drivers/net/can/usb/peak_usb/pcan_usb_core.c | 893 ++++++++++++++++++++++++++ drivers/net/can/usb/peak_usb/peak_usb.h | 149 +++++ 6 files changed, 1073 insertions(+), 0 deletions(-) create mode 100644 drivers/net/can/usb/peak_usb/Kconfig create mode 100644 drivers/net/can/usb/peak_usb/Makefile create mode 100644 drivers/net/can/usb/peak_usb/pcan_usb_core.cWhy not naming the file peak_usb.c? You already use "peak_usb" for the header file as function prefix inside!
AFAIR the driver built results in peak_usb.ko And the driver contains the pcan_usb.c and pcan_usb_pro.c If it's possible from the build process pcan_usb_core.c should be renamed to peak_usb.c - that's right. Regards, Oliver