Re: [PATCH] Add PEAK System USB adapters core driver
From: Marc Kleine-Budde <mkl@pengutronix.de>
Date: 2012-01-10 12:53:19
On 12/22/2011 10:41 PM, Sebastian Haas wrote:
Hi again, some nitpicking this time. ;-) You are mixing pr_*, dev_* and netdev_* please check if it is possible to harmonize the usage.
I think, that you should use netdev_* whenever you have a netdev pointer, dev_* until no netdev has been registered and pr_* if not even a device pointer is available. Marc -- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions | Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917-5555 | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
Attachments
- signature.asc [application/pgp-signature] 262 bytes