Thread (58 messages) 58 messages, 4 authors, 2021-07-29

Re: [PATCH 08/27] iomap: add the new iomap_iter model

From: Christoph Hellwig <hch@lst.de>
Date: 2021-07-26 08:17:39
Also in: linux-fsdevel, linux-xfs, nvdimm

On Tue, Jul 20, 2021 at 07:48:38AM +1000, Dave Chinner wrote:
We should avoid namespace conflicts where function names shadow
object types. iomap_iterate() is fine as the function name - there's
no need for abbreviation here because it's not an overly long name.
This will makes it clearly different to the struct iomap_iter that
is passed to it and it will also make grep, cscope and other
code searching tools much more precise...
Well, there isn't really a conflict by definition.  I actually like
this choice of names (stolen from the original patch from willy)
as it clearly indicates they go together.

But I'm happy to collect a few more opinions.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help