Re: [Patch v2 41/42] btrfs: fix the use-after-free bug in writeback subpage helper

On 21/05/12 09:49AM, Qu Wenruo wrote:

Hi Ritesh,

The patchset gets updated, and I am already running the tests, so far so
good.

Sure, I have started the testing. Will update the results for both
4k, 64k configs with "-g quick", "-g auto" options on PPC64.

The new head is:
commit cb81da05e7899b8196c3c5e0b122798da3b94af0
Author: Qu Wenruo [off-list ref]
Date:   Mon May 3 08:19:27 2021 +0800

    btrfs: remove io_failure_record::in_validation

I may have some minor change the to commit messages and comments
preparing for the next submit, but the code shouldn't change any more.


Just one note, thanks to your report on btrfs/028, I even find a data
corruption bug in relocation code.

Nice :)

Kudos (and of-course Reported-by tags) to you!

Thanks!

New changes since v2 patchset:

- Fix metadata read path ASSERT() when last eb is already dereferred
- Fix read repair related bugs
  * fix possible hang due to unreleased sectors after read error
  * fix double accounting in btrfs_subpage::readers

- Fix false alert when relocating data extent without csum
  This is really a false alert, the expected csum is always 0x00

- Fix a data corruption when relocating certain data extents layout
  This is a real corruption, both relocation and scrub will report
  error.

Thanks for the detailed info.

Thanks and happy testing!

Thanks for the quick replies and all your work in supporting bs < ps.
This is definitely very useful for Power platform too!!

-ritesh