Thread (9 messages) 9 messages, 6 authors, 2021-02-27

Re: [PATCH 1/4] btrfs: add ioctl BTRFS_IOC_DEV_PROPERTIES.

From: Zygo Blaxell <hidden>
Date: 2021-02-27 15:59:18

On Tue, Feb 23, 2021 at 02:53:30PM +0100, David Sterba wrote:
On Mon, Feb 22, 2021 at 10:19:06PM +0100, Goffredo Baroncelli wrote:
quoted
From: Goffredo Baroncelli <redacted>

This ioctl is a base for returning / setting information from / to  the
fields of the btrfs_dev_item object.
Please don't add a new ioctl for properties, they're using the xattr as
interface alrady.
We had some earlier discussion about why xattrs on an inode are a
bad idea for this feature:

	https://lore.kernel.org/linux-btrfs/20210123172118.GJ28049@hungrycats.org/ (local)

TL;DR they shouldn't be copied from one filesystem to another.

Maybe it's better from a CLI UI point of view to put them under 'btrfs
dev' instead of 'btrfs property'?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help