Re: [PATCH 1/4] btrfs: add ioctl BTRFS_IOC_DEV_PROPERTIES.
From: Goffredo Baroncelli <hidden>
Date: 2021-02-23 18:00:41
From: Goffredo Baroncelli <hidden>
Date: 2021-02-23 18:00:41
On 2/23/21 2:53 PM, David Sterba wrote:
On Mon, Feb 22, 2021 at 10:19:06PM +0100, Goffredo Baroncelli wrote:quoted
From: Goffredo Baroncelli <redacted> This ioctl is a base for returning / setting information from / to the fields of the btrfs_dev_item object.
Hi David,
Please don't add a new ioctl for properties, they're using the xattr as interface alrady. how it is supposed to work with a device ?
I have to point out that the property is already exported in sysfs. However I read a comment in sysfs code that discourages to make a filesystem updating (open a new transaction) in the sysfs handler. Do you have any suggestion ? Thanks in advance BR Goffredo -- gpg @keyserver.linux.it: Goffredo Baroncelli <kreijackATinwind.it> Key fingerprint BBF5 1610 0B64 DAC6 5F7D 17B2 0EDA 9B37 8B82 E0B5