Thread (52 messages) 52 messages, 5 authors, 2021-02-04

Re: [PATCH v5 00/18] btrfs: add read-only support for subpage sector size

From: David Sterba <hidden>
Date: 2021-01-28 10:37:56

On Thu, Jan 28, 2021 at 08:30:21AM +0800, Qu Wenruo wrote:
quoted
quoted
   btrfs: support subpage for extent buffer page release
I don't have this patch in my inbox so I can't reply to it directly, but
you include refcount.h, but then use normal atomics.  Please used the
actual refcount_t, as it gets us all the debugging stuff that makes
finding problems much easier.  Thanks,
My bad, my initial plan is to use refcount, but the use case has valid 0
refcount usage, thus refcount is not good here.
In case you need to shift the "0" you can use refcount_dec_not_one or
refcount_inc/dec_not_zero, but I haven't seen the code so don't know if
this applies in your case.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help