Thread (52 messages) 52 messages, 5 authors, 2021-02-04

Re: [PATCH v5 13/18] btrfs: introduce read_extent_buffer_subpage()

From: Josef Bacik <josef@toxicpanda.com>
Date: 2021-01-27 16:42:18

On 1/26/21 3:33 AM, Qu Wenruo wrote:
Introduce a helper, read_extent_buffer_subpage(), to do the subpage
extent buffer read.

The difference between regular and subpage routines are:

- No page locking
   Here we completely rely on extent locking.
   Page locking can reduce the concurrency greatly, as if we lock one
   page to read one extent buffer, all the other extent buffers in the
   same page will have to wait.

- Extent uptodate condition
   Despite the existing PageUptodate() and EXTENT_BUFFER_UPTODATE check,
   We also need to check btrfs_subpage::uptodate_bitmap.

- No page iteration
   Just one page, no need to loop, this greatly simplified the subpage
   routine.

This patch only implements the bio submit part, no endio support yet.

Signed-off-by: Qu Wenruo <redacted>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
Reviewed-by: Josef Bacik <josef@toxicpanda.com>

Thanks,

Josef
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help