Thread (15 messages) 15 messages, 6 authors, 2021-01-12

Re: [PATCH 2/2] btrfs: send: fix invalid commands for inodes with changed type but same gen

From: Roman Anasal | BDSU <hidden>
Date: 2021-01-11 21:32:22

On Mon, 2021-01-11 at 22:15 +0100, David Sterba wrote:
On Mon, Jan 11, 2021 at 08:02:43PM +0100, Roman Anasal wrote:
quoted
--- a/fs/btrfs/send.c
+++ b/fs/btrfs/send.c
@@ -6299,12 +6299,18 @@ static int changed_inode(struct send_ctx
*sctx,
 		right_gen = btrfs_inode_generation(sctx->right_path-
quoted
nodes[0],
 				right_ii);
 
+		u64 left_type = S_IFMT & btrfs_inode_mode(
+				sctx->left_path->nodes[0], left_ii);
+		u64 right_type = S_IFMT & btrfs_inode_mode(
+				sctx->right_path->nodes[0], right_ii);
Minor note, we don't use the declarations mixed with code, so the
variables need to be declared separatelly, but I can fix that unless
there's another reason to update and resend the patches.
Ah yes, I was quite unsure where to put the declarations and then
wanted to put them as close as possible to the usage and decided to put
them in the same "scope".
But just now I realised I was still thinking in the wrong programming
language and there is no "if-block-scope" in C :D

So I updated the commit respectively and can resend if needed.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help