Re: [PATCH 11/29] btrfs: remove unused parameter from btrfs_check_super_valid
From: Liu Bo <hidden>
Date: 2017-02-14 18:45:34
From: Liu Bo <hidden>
Date: 2017-02-14 18:45:34
On Tue, Feb 14, 2017 at 12:42:07PM +0100, David Sterba wrote:
On Mon, Feb 13, 2017 at 06:11:56PM -0800, Liu Bo wrote:quoted
On Mon, Feb 13, 2017 at 10:33:55AM +0100, David Sterba wrote:quoted
None of the checks need to know the RO/RW status.OK...there was a readonly check, which lets us skip all checks, it was removed by the below commit, should we add the check back?All the current checks do not modify the superblock, so it's read-only and we can keep it as-is. The superblock is available from inside the function anyway so we don't need to check sb_flags externally. I'll update the changelog.
Yes, this makes sense. Thanks, -liubo