Re: [PATCH V5 1/2] Btrfs: cleanup duplicated division functions
From: David Sterba <hidden>
Date: 2012-09-28 10:10:02
On Fri, Sep 28, 2012 at 09:49:13AM +0800, Miao Xie wrote:
quoted hunk ↗ jump to hunk
diff --git a/fs/btrfs/math.h b/fs/btrfs/math.h new file mode 100644 index 0000000..4fef49f --- /dev/null +++ b/fs/btrfs/math.h@@ -0,0 +1,35 @@ + +/* + * Copyright (C) 2012 Fujitsu. All rights reserved. + * Written by Miao Xie <miaox@cn.fujitsu.com> + * + * This program is free software; you can redistribute it and/or + * modify it under the terms of the GNU General Public + * License v2 as published by the Free Software Foundation. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * General Public License for more details. + * + * You should have received a copy of the GNU General Public + * License along with this program; if not, write to the + * Free Software Foundation, Inc., 59 Temple Place - Suite 330, + * Boston, MA 021110-1307, USA. + */ + +#ifndef __BTRFS_MATH_H +#define __BTRFS_MATH_H + +#include <asm/div64.h> + +static inline u64 div_factor(u64 num, int factor) +{ + WARN_ON(factor > 100 || factor < 0); + + num *= factor; + do_div(num, 100); + return num; +} + +#endif
Sorry no, a 4 line function does not deserve a separate file. david